玄铁全系列RISC-V内核支持(E系列/R系列/C系列)#10343
Conversation
|
@Yaochenger 请先修复CI的报错,然后相关的BSP可以添加到CI看护里面😊 |
📌 Code Review Assignment🏷️ Tag: workflowPath: Changed Files (Click to expand)
📊 Current Review Status (Last Updated: 2025-06-10 01:50 UTC)
📝 Review Instructions
|
There was a problem hiding this comment.
Pull Request Overview
This PR aims to add comprehensive support for the XuanTie RISC-V cores across the E, R, and C series by removing obsolete/system-specific implementations and updating build configurations.
- Legacy system initialization, startup, and trap handling files for various architectures (e.g., c907fd, c907fd-rv32, c906fdv, etc.) have been removed.
- The linker script’s minimum heap size has been increased significantly, and the BSP compile configuration JSON has been updated to include additional board configurations.
Reviewed Changes
Copilot reviewed 314 out of 314 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| bsp/xuantie/libraries/xuantie_libraries/chip_riscv_dummy/src/arch/* | Removal of legacy system, startup, and trap handling code for various chip variants to consolidate or replace with new implementations |
| bsp/xuantie/libraries/xuantie_libraries/chip_riscv_dummy/gcc_flash_xiaohui.ld | Increased __min_heap_size value to support new platform memory requirements |
| .github/ALL_BSP_COMPILE.json | Updated BSP sub-configurations to include new board variants |
Comments suppressed due to low confidence (2)
bsp/xuantie/libraries/xuantie_libraries/chip_riscv_dummy/src/arch/c907fd/system.c:1
- Multiple system initialization and trap handling files have been removed across various architectures; please confirm that all dependent modules have been updated to use the new consolidated support for RISC-V cores to avoid unresolved references.
/* entire file removal */
bsp/xuantie/libraries/xuantie_libraries/chip_riscv_dummy/gcc_flash_xiaohui.ld:24
- The minimum heap size has been increased from 0x200 to 0x20000; please verify that this new value meets the memory requirements of the updated configurations and does not introduce unintended memory overhead.
__min_heap_size = 0x20000;
| objs = [] | ||
| list = os.listdir(cwd) | ||
|
|
||
| for d in list: |
|
|
||
| config SOC_XUANTIE | ||
| bool | ||
| select SOC_XUANTIE_SERIES_E906 |
|
|
||
| config SOC_XUANTIE | ||
| bool | ||
| select SOC_XUANTIE_SERIES_E906 |
|
|
||
| config SOC_XUANTIE | ||
| bool | ||
| select SOC_XUANTIE_SERIES_E906 |
拉取/合并请求描述:(PR description)
[
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up