[libcpu/common] 修正对RV32E的支持,移除无用文件#10339
Merged
Rbb666 merged 2 commits intoRT-Thread:masterfrom May 30, 2025
Merged
Conversation
aozima
reviewed
May 29, 2025
| lw s2, 0(s0) | ||
| beqz s2, spurious_interrupt | ||
| lw s1, 0(s0) | ||
| beqz s1, spurious_interrupt |
Member
There was a problem hiding this comment.
这里更换为S1的原理是啥?最好能在commit中说明。
另外技术类修改,和文件的增减,最好分开commit.
Contributor
Author
There was a problem hiding this comment.
已拆分为2个commit并描述修改的原因
supperthomas
approved these changes
May 29, 2025
Rbb666
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
1.修正libcpu/common对RV32E的支持,RV32E不支持s2寄存器,修改为s1寄存器
2.移除无用文件,在RV32下中断管理器的支持较为丰富,所以该文件没有存在这里的必要,更多的是放在BSP中,且当前的RV32 BSP均未使用该文件
你的解决方案是什么 (what is your solution)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up