Skip to content

[bsp]增加超睿DP1000 bsp支持#10338

Merged
Rbb666 merged 6 commits intoRT-Thread:masterfrom
ultrarisc:ur_dp1000_bsp
May 30, 2025
Merged

[bsp]增加超睿DP1000 bsp支持#10338
Rbb666 merged 6 commits intoRT-Thread:masterfrom
ultrarisc:ur_dp1000_bsp

Conversation

@zhangjing0303
Copy link
Contributor

@zhangjing0303 zhangjing0303 commented May 29, 2025

拉取/合并请求描述：(PR description)

[

为什么提交这份PR (why to submit this PR)

支持超睿DP1000 BSP。

你的解决方案是什么 (what is your solution)

1、增加libcpu/risc-v/ultrarisc/ur-cp100目录，支持超睿ur-cp100 cpu核；
2、增加bsp/ultrarisc目录，支持超睿dp1000 evb bsp。

请提供验证的bsp和config (provide the config and bsp)

  • BSP: bsp/ultrarisc/ur_dp1000_evb
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality：

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确，包括缩进空格，命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码，代码尽量精简，不包含#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的，并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/workflows/bsp_buildings.yml 详细请参考链接BSP自查

@github-actions github-actions bot added BSP action github action yml imporve Arch: RISC-V BSP related with risc-v libcpu labels May 29, 2025
@github-actions
Copy link

github-actions bot commented May 29, 2025 •
edited
Loading

📌 Code Review Assignment

🏷️ Tag: workflow

Path: .github
Reviewers: supperthomas Rbb666 kurisaW

Changed Files (Click to expand)
  • .github/ALL_BSP_COMPILE.json

📊 Current Review Status (Last Updated: 2025-05-30 03:27 UTC)

  • ⌛ Rbb666 Pending Review
  • ⌛ kurisaW Pending Review
  • ⌛ supperthomas Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

Rbb666
Rbb666 reviewed May 29, 2025
View reviewed changes
bsp/ultrarisc/drivers/drv_dw_spi.c Outdated
{
return tx_left < tx_room ? tx_left : tx_room;
}

Copy link
Member

@Rbb666 Rbb666 May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多余的换行请删除

bsp/ultrarisc/drivers/SConscript Outdated

list = os.listdir(cwd)

for item in list:
Copy link
Member

@Rbb666 Rbb666 May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段代码对于此目录结构多余了

bsp/ultrarisc/ur_dp1000_evb/README.md Outdated

zhangjing@ultrarisc.com。


Copy link
Member

@Rbb666 Rbb666 May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

多余的换行请删除

aozima
aozima reviewed May 29, 2025
View reviewed changes
libcpu/risc-v/ultrarisc/ur-cp100/cache.c Outdated

rt_inline rt_uint32_t rt_cpu_dcache_line_size()
{
return 0;
Copy link
Member

@aozima aozima May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

有cache的情况下，cache line不太可能为0吧？而且这个在C文件中，但下面没有被引用到，那么没用的代码应该被删除掉。

Copy link
Contributor Author

@zhangjing0303 zhangjing0303 May 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我先改下，cache这块的代码后续还需要整理，我这版先把必要接口实现。

Yaochenger
Yaochenger reviewed May 29, 2025
View reviewed changes
Copy link
Contributor

@Yaochenger Yaochenger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

建议将ultrarisc/ur-cp100目录下的文件移动至bsp目录下同时移除多余的文件，libcpu下不建议再添加类似文件！

@zhangjing0303
Copy link
Contributor Author

zhangjing0303 commented May 29, 2025

建议将ultrarisc/ur-cp100目录下的文件移动至bsp目录下同时移除多余的文件，libcpu下不建议再添加类似文件！

这部分代码是否是后续rv64体系结构相关的功能完全统一掉再按你的建议来？

@supperthomas supperthomas added the BSP: new bsp board New added bsp, need sync action label May 29, 2025
@Yaochenger
Copy link
Contributor

Yaochenger commented May 30, 2025

建议将ultrarisc/ur-cp100目录下的文件移动至bsp目录下同时移除多余的文件，libcpu下不建议再添加类似文件！

这部分代码是否是后续rv64体系结构相关的功能完全统一掉再按你的建议来？

现在有人在做相关的rv64统一工作，如果任然加在这里会对后续的整理工作造成负担，不排除后续其他人效仿将这个文件加越来越大

给出一下建议：
1.放在application文件夹下
2.在该目录下，移除本次提交未使用的文件，仅保留和该笔提交相关的文件

@Yaochenger
Copy link
Contributor

Yaochenger commented May 30, 2025

建议将ultrarisc/ur-cp100目录下的文件移动至bsp目录下同时移除多余的文件，libcpu下不建议再添加类似文件！

这部分代码是否是后续rv64体系结构相关的功能完全统一掉再按你的建议来？

现在有人在做相关的rv64统一工作，如果任然加在这里会对后续的整理工作造成负担，不排除后续其他人效仿将这个文件加越来越大

给出一下建议： 1.放在application文件夹下 2.在该目录下，移除本次提交未使用的文件，仅保留和该笔提交相关的文件

后续这部分会配置成可选项，通用的文件用户用到的在配置中开启即可

@zhangjing0303
Copy link
Contributor Author

zhangjing0303 commented May 30, 2025

建议将ultrarisc/ur-cp100目录下的文件移动至bsp目录下同时移除多余的文件，libcpu下不建议再添加类似文件！

这部分代码是否是后续rv64体系结构相关的功能完全统一掉再按你的建议来？

现在有人在做相关的rv64统一工作，如果任然加在这里会对后续的整理工作造成负担，不排除后续其他人效仿将这个文件加越来越大
给出一下建议： 1.放在application文件夹下 2.在该目录下，移除本次提交未使用的文件，仅保留和该笔提交相关的文件

后续这部分会配置成可选项，通用的文件用户用到的在配置中开启即可以
已按你的建议修改，将Ultrarisc cpu相关内容移到bsp中

@Rbb666 Rbb666 requested a review from Yaochenger May 30, 2025 03:34
@Rbb666 Rbb666 merged commit c3d33f3 into RT-Thread:master May 30, 2025
59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aozima aozima aozima left review comments

@Rbb666 Rbb666 Rbb666 approved these changes

@supperthomas supperthomas Awaiting requested review from supperthomas supperthomas is a code owner

+1 more reviewer

@Yaochenger Yaochenger Yaochenger approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action github action yml imporve Arch: RISC-V BSP related with risc-v BSP: new bsp board New added bsp, need sync action BSP libcpu

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@zhangjing0303 @Yaochenger @aozima @Rbb666 @supperthomas