Add some bsp driver for HC32F4A8.#10333
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support and driver updates for the HC32F4A8 MCU variant, extending existing HAL layers and board configurations.
- Enable HC32F4A8 in RTC, PM, MCAN, ETH, and DAC drivers
- Introduce VBAT power-down check for RTC initialization
- Update board-specific ports, Kconfig entries, and application code for F4A8
Reviewed Changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| bsp/hc32/libraries/hc32_drivers/drv_rtc.c | Add F4A8 support and VBAT power-down check |
| bsp/hc32/libraries/hc32_drivers/drv_pm.h | Extend EFM readiness check to F4A8 |
| bsp/hc32/libraries/hc32_drivers/drv_pm.c | Include F4A8 in deep-sleep and run-mode transitions |
| bsp/hc32/libraries/hc32_drivers/drv_mcan.c | Update MCAN ISR to accept int_sel parameter |
| bsp/hc32/libraries/hc32_drivers/drv_eth.c | Adapt PHY address handling and auto-negotiation config for F4A8 |
| bsp/hc32/libraries/hc32_drivers/drv_dac.h | Extend DAC init struct with new F4A8 channel parameters |
| bsp/hc32/libraries/hc32_drivers/drv_dac.c | Implement channel init logic for F4A8 DAC ports |
| bsp/hc32/ev_hc32f4a8_lqfp176/board/{ports,config,board_config.c,hc32f4xx_conf.h,Kconfig} | Add board-level port mappings, DAC/Kconfig updates, and FCM application changes for F4A8 |
Comments suppressed due to low confidence (2)
bsp/hc32/libraries/hc32_drivers/drv_rtc.c:202
- [nitpick] The function
VBAT_PowerDownCheckuses PascalCase and no underscore prefix, which is inconsistent with other static helper functions; consider renaming to_vbat_power_down_checkto match existing naming conventions.
static en_flag_status_t VBAT_PowerDownCheck(void)
bsp/hc32/libraries/hc32_drivers/drv_mcan.c:862
- The
mcan_isrdefinition was changed to accept two parameters, but any forward declarations or other references expecting a single-parameter signature will break; ensure the prototype is updated everywhere (including headers) to match this new signature.
rt_inline void mcan_isr(hc32_mcan_driver_t *driver, uint32_t int_sel)
这个PR还有什么问题要处理吗？没有看到新的异常 |
|
|
请针对某一款常用的bsp，添加对应yml文件，方便其他人知道如何使用这些driver 添加yml参考如下： https://club.rt-thread.org/ask/article/5c41835bb8ff9b41.html https://club.rt-thread.org/ask/article/d273bbcd1f8779bc.html |
|
@JamieTx 作者是否有意愿维护此BSP,可以申请加入审核团：https://github.com/RT-Thread/rt-thread/blob/master/MAINTAINERS |
3 participants
拉取/合并请求描述：(PR description)
[
Add some bsp driver for HC32F4A8.
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality：
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码，不包含已经被注释了的代码 All redundant code is removed and cleaned up