[FIX AARCH64] Fix Aarch64 architecture runtime issues#10232
Merged
Rbb666 merged 2 commits intoRT-Thread:masterfrom Apr 28, 2025
Merged
[FIX AARCH64] Fix Aarch64 architecture runtime issues#10232Rbb666 merged 2 commits intoRT-Thread:masterfrom
Rbb666 merged 2 commits intoRT-Thread:masterfrom
Conversation
该问题由5b3320624da5149fc21c2d3e1f321d855e3d0dfe引入,导致工具链编译时加上了 -std=gnu99,其他架构是否出问题暂时未知
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes Aarch64 runtime issues by removing the unintended addition of the -std=gnu99 flag for the Kernel project during the build process.
- Introduces a new function to strip the -std=gnu99 flag from Compiler Flags
- Registers a pre-building action to apply this change for Aarch64 builds
Comments suppressed due to low confidence (2)
libcpu/aarch64/SConscript:27
- [nitpick] Consider renaming 'del_gnu99' to 'remove_gnu99_flag' for improved clarity.
def del_gnu99():
libcpu/aarch64/SConscript:27
- [nitpick] Adding a brief docstring for this function could help clarify its purpose for future maintainers.
def del_gnu99():
Member
Member
|
错误截图有吗? |
Contributor
Author
CI问题已经解决 |
Contributor
Author
supperthomas
approved these changes
Apr 25, 2025
Member
|
是这里引入的 RT_USING_HOOKLIST with gnu99 |
Member
|
是不是这类平台不支持gnu99参数? |
Member
在smart上应该是的,所以这个问题是否可以不是这样处理? |
Member
要么这种带有gnu的平台toolchain改成特定的,不要用gcc,改为gccgnu? 或者你们看看有什么建议,mcu平台这些都是要加的,因为很多平台是没有这种参数的。 |
Rbb666
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


该问题由5b3320624da5149fc21c2d3e1f321d855e3d0dfe引入,导致工具链编译时加上了 -std=gnu99,其他架构是否出问题暂时未知
拉取/合并请求描述:(PR description)
[
为什么提交这份PR (why to submit this PR)
你的解决方案是什么 (what is your solution)
请提供验证的bsp和config (provide the config and bsp)
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up