[hc32] Add the ev_hc32f4a8_lqfp176 board and modify some bsp drivers.#10228
Closed
JamieTx wants to merge 4 commits intoRT-Thread:masterfrom
Closed
[hc32] Add the ev_hc32f4a8_lqfp176 board and modify some bsp drivers.#10228JamieTx wants to merge 4 commits intoRT-Thread:masterfrom
JamieTx wants to merge 4 commits intoRT-Thread:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for the new ev_hc32f4a8_lqfp176 board and makes corresponding improvements to various BSP drivers, while also updating some peripheral configurations for existing boards.
- Added SConstruct and SConscript for the new board build process
- Updated interrupt, DMA, and flash configuration settings across several boards
- Modified CAN configurations by replacing can_config with mcan_config in some boards
Reviewed Changes
Copilot reviewed 105 out of 109 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| bsp/hc32/ev_hc32f4a8_lqfp176/SConstruct | New board build file with proper environment and building setup |
| bsp/hc32/ev_hc32f4a8_lqfp176/SConscript | Board module compilation script with file path adjustments and keyword replacements |
| bsp/hc32/ev_hc32f4a8_lqfp176/README.md | Documentation for the new board |
| bsp/hc32/ev_hc32f4a0_lqfp176/* | Updated IRQ, DMA, flash config macros to support additional channels |
| bsp/hc32/ev_hc32f472_lqfp100/* | Removed SPI5/6 and updated flash granularities |
| bsp/hc32/ev_hc32f448_lqfp80/* | Replacement of can_config with mcan_config and related function renaming |
| bsp/hc32/ev_hc32f460_lqfp100_v2/* | Updated flash granularity macros |
Files not reviewed (4)
- bsp/hc32/ev_hc32f4a8_lqfp176/.cproject: Language not supported
- bsp/hc32/ev_hc32f4a8_lqfp176/.gitignore: Language not supported
- bsp/hc32/ev_hc32f4a8_lqfp176/.project: Language not supported
- bsp/hc32/ev_hc32f4a8_lqfp176/Kconfig: Language not supported
Comments suppressed due to low confidence (1)
bsp/hc32/ev_hc32f4a8_lqfp176/SConscript:8
- The variable name 'list' shadows the built-in Python type; consider renaming it to something like 'dir_list' or 'entries'.
list = os.listdir(cwd)
Comment on lines
33
to
41
| file_path = cwd + './jlink/ev_hc32f4a8_lqfp176 Debug.launch' | ||
| svd_keyword = 'HC32F4A8.svd' | ||
| split_num = 3 | ||
| elif rtconfig.PLATFORM in ['armcc', 'armclang']: | ||
| file_path = cwd + './template.uvprojx' | ||
| svd_keyword = 'HC32F4A8.SFR' | ||
| split_num = 2 | ||
| elif rtconfig.PLATFORM in ['iccarm']: | ||
| file_path = cwd + '/project.ewd' |
There was a problem hiding this comment.
Concatenating 'cwd' with a relative path string may result in an incorrect file path; consider using os.path.join(cwd, 'jlink', 'ev_hc32f4a8_lqfp176 Debug.launch') to ensure proper path construction.
Suggested change
| file_path = cwd + './jlink/ev_hc32f4a8_lqfp176 Debug.launch' | |
| svd_keyword = 'HC32F4A8.svd' | |
| split_num = 3 | |
| elif rtconfig.PLATFORM in ['armcc', 'armclang']: | |
| file_path = cwd + './template.uvprojx' | |
| svd_keyword = 'HC32F4A8.SFR' | |
| split_num = 2 | |
| elif rtconfig.PLATFORM in ['iccarm']: | |
| file_path = cwd + '/project.ewd' | |
| file_path = os.path.join(cwd, 'jlink', 'ev_hc32f4a8_lqfp176 Debug.launch') | |
| svd_keyword = 'HC32F4A8.svd' | |
| split_num = 3 | |
| elif rtconfig.PLATFORM in ['armcc', 'armclang']: | |
| file_path = os.path.join(cwd, 'template.uvprojx') | |
| svd_keyword = 'HC32F4A8.SFR' | |
| split_num = 2 | |
| elif rtconfig.PLATFORM in ['iccarm']: | |
| file_path = os.path.join(cwd, 'project.ewd') |
supperthomas
requested changes
Apr 26, 2025
| }, | ||
| { | ||
| "RTT_BSP": "K230", | ||
| "RTT_TOOL_CHAIN": "riscv64-unknown-linux-musl-", |
Member
There was a problem hiding this comment.
应该改不到这里的代码,估计git操作哪里不对。
下次可以用下面两个命令
git fetch origin
git rebase origin/master
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
拉取/合并请求描述:(PR description)
[
Add the ev_hc32f4a8_lqfp176 board and modify some bsp drivers.
]
当前拉取/合并请求的状态 Intent for your PR
必须选择一项 Choose one (Mandatory):
代码质量 Code Quality:
我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:
#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up