Conversation
|
@CYFS3 又失效个软件包==，还点麻烦提交一份 
|
There was a problem hiding this comment.
Pull request overview
This PR adds a new WiFi driver package for the GD32VW55x series microcontroller to the RT-Thread package repository. The package provides WiFi functionality with support for Station and SoftAP modes, various security protocols (WPA/WPA2/WPA3), and configurable power management options.
Changes:
- Added package.json with metadata, dependencies, and repository information for gd32vw55x-wifi
- Added Kconfig file with comprehensive configuration options for WiFi features, security, power management, and debugging
- Integrated the new package into the GD32 peripheral menu by adding a source directive in the parent Kconfig
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| peripherals/hal-sdk/gd32/gd32vw55x-wifi/package.json | Defines package metadata, dependencies on LWIP and DFS, and repository location |
| peripherals/hal-sdk/gd32/gd32vw55x-wifi/Kconfig | Provides extensive configuration options for WiFi modes, security, buffer sizes, task priorities, and power management |
| peripherals/hal-sdk/gd32/Kconfig | Adds source statement to include the new gd32vw55x-wifi package in the build configuration menu |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| { | ||
| "name": "gd32vw55x-wifi", | ||
| "description": "GD32VW55x WIFI driver package for RT-Thread", | ||
| "description_zh": "GD32VW55x WIFI 驱动包", | ||
| "enable": "PKG_USING_GD32VW55X_WIFI", | ||
| "keywords": [ | ||
| "wifi", | ||
| "gd32", | ||
| "gd32vw55x", | ||
| "wireless", | ||
| "802.11" | ||
| ], | ||
| "category": "peripherals", | ||
| "author": { | ||
| "name": "GigaDevice", | ||
| "email": "support@gigadevice.com" | ||
| }, | ||
| "license": "BSD-3-Clause", | ||
| "repository": "https://github.com/RT-Thread-packages/gd32vw55x-wifi", | ||
| "icon": "unknown", | ||
| "homepage" : "https://github.com/RT-Thread-packages/gd32vw55x-wifi#readme", | ||
| "doc": "unknown", | ||
| "dependencies": { | ||
| "RT_USING_LWIP": ">=2.0.0", | ||
| "RT_USING_DFS": ">=1.0.0" | ||
| }, | ||
| "site": [ | ||
| { | ||
| "version": "latest", | ||
| "URL": "https://github.com/RT-Thread-packages/gd32vw55x-wifi.git", | ||
| "filename": "", | ||
| "VER_SHA": "master" | ||
| } | ||
| ] | ||
| } |
There was a problem hiding this comment.
The indentation in this file uses 4 spaces, which is inconsistent with other package.json files in the same directory (gd32-arm-cmsis, gd32-arm-series, gd32-riscv-series) that use 2-space indentation. Please update the indentation to use 2 spaces for consistency across the codebase.
| "license": "BSD-3-Clause", | ||
| "repository": "https://github.com/RT-Thread-packages/gd32vw55x-wifi", | ||
| "icon": "unknown", | ||
| "homepage" : "https://github.com/RT-Thread-packages/gd32vw55x-wifi#readme", |
There was a problem hiding this comment.
There is an extra space before the colon in the "homepage" field. This is inconsistent with the formatting of other fields in this file and other package.json files in the repository. Please remove the extra space to maintain consistency.
| "homepage" : "https://github.com/RT-Thread-packages/gd32vw55x-wifi#readme", | |
| "homepage": "https://github.com/RT-Thread-packages/gd32vw55x-wifi#readme", |
| string | ||
| default "latest" if PKG_USING_GD32VW55X_WIFI_LATEST_VERSION |
There was a problem hiding this comment.
The indentation on this line uses 7 spaces, which is inconsistent with the 8-space indentation used for similar config lines elsewhere in the file (e.g., line 23). Please adjust the indentation to match the rest of the file for consistency.
| string | |
| default "latest" if PKG_USING_GD32VW55X_WIFI_LATEST_VERSION | |
| string | |
| default "latest" if PKG_USING_GD32VW55X_WIFI_LATEST_VERSION |
麻烦新建仓库，并且给我可以直接推送仓库的权限 |
2 participants
No description provided.