feat(nodectl): refresh past_elections cache periodically#176
Open
Keshoid wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
past_electionsand pool-address caches (currently invalidated only onelection_idchange, i.e. once per ~9h round).frozen_staketo 2× the real value.elections.cache_refresh_secs(default300, set0to disable). Hot-reloaded via the 10s config-file watch.past_elections cache refreshed (reason=election_id|ttl, ...)on each refresh so the trigger is visible in the daemon log.Clocktrait introduced incommon(productionSystemClock, deterministicMockClock) so the TTL logic is unit-testable without real-time sleeps.run_singlehost_nodectl.py) setscache_refresh_secs=60afterconfig generateso the periodic refresh is exercised in the e2e log.Closes SMA-98.