Fix blank token name in variable prompt when GM name is empty#5955
Open
evanofficial wants to merge 1 commit intoRPTools:developfrom
Open
Fix blank token name in variable prompt when GM name is empty#5955evanofficial wants to merge 1 commit intoRPTools:developfrom
evanofficial wants to merge 1 commit intoRPTools:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5339
When a token's GM name is cleared (set to
""instead ofnull), the variable prompt dialog shows a blank name or just a period. This is becausegetGMName() != nulldoesn't catch empty strings.Replaced the
nullchecks withStringUtil.isEmpty()so bothnulland""are handled consistently, falling back to the token's regular name when the GM name is empty.This change is