-
Notifications
You must be signed in to change notification settings - Fork 274
States and bars on stat sheets #5924
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
bubblobill
wants to merge
15
commits into
RPTools:develop
Choose a base branch
from
bubblobill:states_and_bars_on_stat_sheets
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
States and bars on stat sheets #5924
bubblobill
wants to merge
15
commits into
RPTools:develop
from
bubblobill:states_and_bars_on_stat_sheets
+403
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShapeDrawable and AbstractDrawing. - On FALSE it returns the Zone.Layer.name() instead of Zone.Layer.value()
ShapeDrawable and AbstractDrawing. - On FALSE it returns the Zone.Layer.name() instead of Zone.Layer.value()
… states_and_bars_on_stat_sheets
1. increased visibility of Property class to get rid of annoying warning 2. created local booleans "playerOwns" and "playerIsGm" in constructor to avoid repetitive lookups. 3. Added bar and state data to the class.
-Rearranged HandlebarsUtil to make getting Handlebars instance easier externally. - Created HBDebugUtil for creating the files in the log directory. - Created a couple of templates for formatting the output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug or Feature request
closes #4149
resolves #4149
Description of the Change
Added token state and bar information to StatSheetContext
Sample output using additional information:

Possible Drawbacks
stymies potential rewrites of states and bars into something sensible
Documentation Notes
State and Bar information available for use in Stat-Sheets
Release Notes
State and Bar information available for use in Stat-Sheets
This change is