[Inductor] Fix flaky epilogue fusion tests by adding missing tearDown…#3244
Merged
Conversation
…Class (pytorch#180736) TestPrologueFusion and TestEpilogueFusionStaticAnalysis both use ExitStack in setUpClass to apply config.patch(), but neither defined tearDownClass to close the stack. When TestPrologueFusion runs before TestEpilogueFusionStaticAnalysis in the same process, config values like max_autotune_gemm_backends="TRITON" leak through, removing the aten kernel choice from autotuning and causing test failures. Fixes pytorch#179693 Pull Request resolved: pytorch#180736 Approved by: https://github.com/Skylion007
Collaborator
|
!cherry-pick --onto release/2.11 release/2.10 release/2.9 |
|
Can't perform the cherry-pick keyword: unexpected error Comment processed by Build |
Collaborator
|
!cherry-pick --onto release/2.10 release/2.9 |
|
Created branch autogenerated/release/2.10_cherry-pick_pr-3244 and #3249. It contains a merge conflict. Please resolve it Created branch autogenerated/release/2.9_cherry-pick_pr-3244 and #3250. It contains a merge conflict. Please resolve it Comment processed by Build |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Class (pytorch#180736)
TestPrologueFusion and TestEpilogueFusionStaticAnalysis both use ExitStack in setUpClass to apply config.patch(), but neither defined tearDownClass to close the stack. When TestPrologueFusion runs before TestEpilogueFusionStaticAnalysis in the same process, config values like max_autotune_gemm_backends="TRITON" leak through, removing the aten kernel choice from autotuning and causing test failures.
Fixes pytorch#179693
Pull Request resolved: pytorch#180736
Approved by: https://github.com/Skylion007
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist
Cherry-picked to release/2.10 branch via #3249
Cherry-picked to release/2.9 branch via #3250