Fix configuration errors when using external Boost#8
Closed
jbelloncastro wants to merge 1 commit intodyninst_13from
Closed
Fix configuration errors when using external Boost#8jbelloncastro wants to merge 1 commit intodyninst_13from
jbelloncastro wants to merge 1 commit intodyninst_13from
Conversation
Some targets are missing Boost components in target_link_libraries, leaving some symbols unresolved at link time. Fix Dyninst::Boost_headers target not being found by CMake. This enables configuring rocprof-systems with an external Boost library (`ROCPROFSYS_BUILD_BOOST=OFF`).
Author
|
When I tried to reproduce this problem using a standalone CMake project linking against Dyninst, I couldn't get the same linker errors. I believe the problem comes from the fact that rocprofiler-systems is building Dyninst internally rather than building it using CMake's ExternalProject_*, but I need to verify if this is the case. The changes fix the issues I have found, for the time being. |
|
Sorry, @jbelloncastro, I missed the notification to your pull request. Please try #10. This should address the problem. |
Author
|
No problem! I am good as long as the problem is solved. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Enables configuring rocprof-systems with an external Boost library (
ROCPROFSYS_BUILD_BOOST=OFF).Technical Details
Some targets are missing Boost components in target_link_libraries, leaving some symbols unresolved at link time.
Fix Dyninst::Boost_headers target not being found by CMake.
Test Plan
Configure and build rocprof-systems with an external Boost library, such as the one installed by Ubuntu's DEB package.
Test Result
After the fix, it was possible to build and install rocprof-systems using an external boost installation, reducing the total compilation time significantly.
Submission Checklist