-
Notifications
You must be signed in to change notification settings - Fork 263
[CK_BUILDER] Refactor warp GEMM and conv algorithm concepts #3567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
vpietila-amd
wants to merge
91
commits into
develop
Choose a base branch
from
vpietila/ckb-refactor-warp-gemm-descriptors
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[CK_BUILDER] Refactor warp GEMM and conv algorithm concepts #3567
vpietila-amd
wants to merge
91
commits into
develop
from
vpietila/ckb-refactor-warp-gemm-descriptors
+1,298
−948
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing representations.
…factor-warp-gemm-descriptors
…m to ThreadClusterRank.
… TileTransferParameters concept for conv algorithms.
…s' into vpietila/ckb-refactor-warp-gemm-descriptors
…tor-warp-gemm-descriptors
…tor-warp-gemm-descriptors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR has four main changes
WarpGemmDescriptorconcept and corresponding types.XDL,WMMA, andDL. The XDL and WMMA algorithm have a common base algorithm conceptConvAlgorithmfrom which the hierarchy ofXDLandWMMAalgorithms is derived.The unified warp GEMM description (item 1.) allows us to treat XDL and WMMA algorithms at unique footing and reduces the amount of boilerplate code.
The hierarchical description of the conv algorithms (item 2.) simplifies the convolution algorithm concepts and allows better compile-time error messages when no corresponding factory is found for a given algorithms description.
Items 1. and 2. combined allow easier addition of new factories.