Skip to content

[CK_BUILDER] Convert convolution traits to a struct with factory functions #3547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
shumway wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

[CK_BUILDER] Convert convolution traits to a struct with factory functions #3547

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
56e49c5
Factor helpers out of conv_traits.hpp
shumway Jan 6, 2026
a47bef9
Create a non-templated conv_traits struct
shumway Jan 6, 2026
d883946
Migrate to new instance-specific instance_to_conv_traits functions
shumway Jan 7, 2026
3c4553e
Clean up reflection concepts
shumway Jan 8, 2026
230b6dd
Clean up ConvTraits helpers
shumway Jan 8, 2026
e58fc46
Update testing for convolution traits
shumway Jan 8, 2026
815cb5f
Address reviewer comments and resolve merge conflict
shumway Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
61 changes: 35 additions & 26 deletions experimental/builder/include/ck_tile/builder/reflect/conv_describe.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,43 +7,52 @@
#pragma once

#include "ck_tile/builder/reflect/conv_description.hpp"
#include "ck_tile/builder/reflect/conv_traits.hpp"
#include "ck_tile/builder/reflect/instance_to_conv_traits.hpp"

namespace ck_tile::reflect {

/// @brief Factory function to create ConvDescription from a convolution instance type
/// @tparam Instance The convolution instance type (must have ConvTraits)
/// @return A ConvDescription object populated with the instance's configuration details
template <conv::HasConvTraits Instance>
/// @brief Concept to check if an Instance type has conv traits
template <typename Instance>
concept HasConvTraits = requires {
{ conv::instance_to_conv_traits<Instance>() };
};

/// Factory function to create ConvDescription from a convolution instance type
/// Instance The convolution instance type
/// A ConvDescription object populated with the instance's configuration details
///
/// TODO: Fix ConvDescription to just use the ConvTraits directly.
template <typename Instance>
requires HasConvTraits<Instance>
conv::ConvDescription describe()
{
using Traits = conv::ConvTraits<Instance>;
const auto traits = conv::instance_to_conv_traits<Instance>();

return conv::ConvDescription(
conv::ConvSignatureInfo{
.spatial_dim = Traits::spatial_dim,
.direction = Traits::direction,
.input_layout = Traits::layout[0],
.weight_layout = Traits::layout[1],
.output_layout = Traits::layout[2],
.data_type = Traits::data_type,
.input_element_op = Traits::input_element_op,
.weight_element_op = Traits::weight_element_op,
.output_element_op = Traits::output_element_op,
.spatial_dim = traits.spatial_dim,
.direction = traits.direction,
.input_layout = traits.layout[0],
.weight_layout = traits.layout[1],
.output_layout = traits.layout[2],
.data_type = traits.data_type,
.input_element_op = traits.input_element_op,
.weight_element_op = traits.weight_element_op,
.output_element_op = traits.output_element_op,
},
conv::GemmAlgorithmInfo{
.thread_block_size = Traits::thread_block_size,
.tile_dims = Traits::tile_dims,
.warp_gemm = Traits::warp_gemm,
.a_tile_transfer = Traits::a_tile_transfer,
.b_tile_transfer = Traits::b_tile_transfer,
.c_tile_transfer = Traits::c_tile_transfer,
.pipeline_version = Traits::pipeline_version,
.pipeline_scheduler = Traits::pipeline_scheduler,
.conv_specialization = Traits::conv_specialization,
.padding = Traits::gemm_padding,
.thread_block_size = traits.thread_block_size,
.tile_dims = traits.tile_dims,
.warp_gemm = traits.warp_gemm,
.a_tile_transfer = traits.a_tile_transfer,
.b_tile_transfer = traits.b_tile_transfer,
.c_tile_transfer = traits.c_tile_transfer,
.pipeline_version = traits.pipeline_version,
.pipeline_scheduler = traits.pipeline_scheduler,
.conv_specialization = traits.conv_specialization,
.padding = traits.gemm_padding,
},
[]() { return reflect::instance_string<Instance>(); });
[]<typename T = Instance>() { return reflect::instance_string<T>(); });
}

} // namespace ck_tile::reflect
Loading