-
Notifications
You must be signed in to change notification settings - Fork 262
Grouped conv_fwd_bias_bnorm_clamp instances and tests #3525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
I had a look at the test failures myself and found the following tolerances to be sufficient for BF16, F16,iInt initialization, and float initialization: I think the bias bnorm clamp operation at the end just fundamentally magnifies small errors in the gemm, so the tolerances simply need to be higher for this op Also a 1e-3 relative error for f16 (default value in check_err) is very low since that is pretty much exactly a single f16 epsilon. For BF16 this is suddenly a lot more lenient (1e-1 even though the epsilon is only 8 times as large). Also check_err() adds up the relative and absolute tolerance errors, which is dubious. |
Proposed changes
Please describe the motivation behind the pull request, whether it enables a new feature or fixes a bug. If there are associated pull requests or issues, please link them to the pull request.
Checklist
Please put an
xinto the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.clang-formaton all changed filesDiscussion
If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered