[main] Drop missing cp313-cp313t from setuptools/wheel install loop#106
Open
JeniferC99 wants to merge 1 commit into
Open
[main] Drop missing cp313-cp313t from setuptools/wheel install loop#106JeniferC99 wants to merge 1 commit into
JeniferC99 wants to merge 1 commit into
Conversation
The pinned manylinux_2_28_x86_64 base image
(sha256:2147aade9cc6f841c9b610ec7b033299b09e425cd3a652bdf1cb9fc885f86078)
no longer ships /opt/python/cp313-cp313t/. The free-threaded interpreter
moved up with CPython and is now distributed as cp314-cp314t /
cp315-cp315t. Iterating over cp313-cp313t in this RUN therefore aborts
the docker build with exit code 127 ("command not found").
Same root cause as the rocm7.2 fix; the loop was introduced in #66 and
is the only reference to cp313-cp313t in the repo.
Verified locally: docker build of the patched RUN against the same
pinned base digest now completes successfully.
Co-authored-by: Cursor <cursoragent@cursor.com>
There was a problem hiding this comment.
Pull request overview
Fixes manywheel/Dockerfile_2_28 builds failing with exit code 127 by removing a non-existent CPython target (cp313-cp313t) from the setuptools/wheel install loop. This aligns the main branch with the already-applied fix on rocm7.2 (PR #105) and unblocks the py3.13 docker build path.
Changes:
- Remove
cp313-cp313tfrom the/opt/python/...install loop to prevent executing a missing interpreter. - Add inline Dockerfile comments documenting why
cp313-cp313tis not used.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Same fix as #105, applied to
main. Both branches carry the broken loop introduced in #66.manywheel/Dockerfile_2_28aborts every wheel build at step 18:The pinned base image
quay.io/pypa/manylinux_2_28_x86_64@sha256:2147aade9c…no longer ships/opt/python/cp313-cp313t/.What
Drop
cp313-cp313tfrom the loop. It's the only reference in the repo.Test
Verified via #105 (rocm7.2): all four pytorch wheel jobs re-run today with the patched
Dockerfile_2_28successfully build and pushrocm/pytorch-private:manylinux-7.2-compute-rocm-rel-7.2-93.Most directly relevant for this PR: pytorch2.10 #62 (
BUILDER_BRANCH=mainis what this branch will become; today's run used the rocm7.2-based fix branch, identical content for this file). Its wheel-builder pwb pytorch#515 reachesnaming to docker.io/rocm/pytorch-private:manylinux-7.2-compute-rocm-rel-7.2-93 doneat 17:18.