[rocm7.2] Upgrade cmake version to 3.28.4#104
Merged
Conversation
1 task
jithunnair-amd
added a commit
that referenced
this pull request
Apr 17, 2026
Cmake 3.18.4 is not available on pypi anymore Use newer version of cmake: 3.28.4 https://rocm-ci.amd.com/job/pytorch-manylinux-wheel-builder_rel-7.2/389/ Manylinux docker image build passed - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: cpattigi <cpattigi@amd.com> (cherry picked from commit dad1117)
jithunnair-amd
added a commit
that referenced
this pull request
Apr 17, 2026
Cmake 3.18.4 is not available on pypi anymore Use newer version of cmake: 3.28.4 https://rocm-ci.amd.com/job/pytorch-manylinux-wheel-builder_rel-7.2/389/ Manylinux docker image build passed - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: cpattigi <cpattigi@amd.com> (cherry picked from commit dad1117)
jithunnair-amd
added a commit
that referenced
this pull request
Apr 17, 2026
Cmake 3.18.4 is not available on pypi anymore Use newer version of cmake: 3.28.4 https://rocm-ci.amd.com/job/pytorch-manylinux-wheel-builder_rel-7.2/389/ Manylinux docker image build passed - [x] Look over the contributing guidelines at https://github.com/ROCm/ROCm/blob/develop/CONTRIBUTING.md#pull-requests. --------- Co-authored-by: cpattigi <cpattigi@amd.com> (cherry picked from commit dad1117)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Cmake 3.18.4 is not available on pypi anymore
Technical Details
Use newer version of cmake: 3.28.4
Test Plan
https://rocm-ci.amd.com/job/pytorch-manylinux-wheel-builder_rel-7.2/389/
Test Result
Manylinux docker image build passed
Submission Checklist