Skip to content

Conversation

@gyohuangxin
Copy link
Member

@gyohuangxin gyohuangxin commented Dec 25, 2025

Related to https://github.com/orgs/ROCm/projects/48/views/1?filterQuery=sprint%3A%40current+assignee%3A%22gyohuangxin%22&pane=issue&itemId=120791567&issue=ROCm%7Cframeworks-internal%7C12994

  • Optimize the performance summary outputs in test logs.
  • Collect and show the performance summary in an easy-to-read format.

gyohuangxin and others added 4 commits December 25, 2025 13:58
@gyohuangxin gyohuangxin force-pushed the optimize_test_summary branch 3 times, most recently from ad611ee to c129d65 Compare December 29, 2025 02:56
@gyohuangxin gyohuangxin force-pushed the optimize_test_summary branch from c129d65 to 45f9361 Compare December 29, 2025 06:30
@gyohuangxin gyohuangxin force-pushed the optimize_test_summary branch from 4c1833b to 128263b Compare December 29, 2025 07:25
@gyohuangxin gyohuangxin marked this pull request as ready for review December 29, 2025 11:25
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes performance summary outputs in test logs and introduces automated collection of these summaries in an easy-to-read markdown format for CI workflows.

Key changes:

  • Converts pandas DataFrame summary outputs to markdown format using to_markdown() across all operator test files
  • Adds a new Python script (collect_logs.py) to extract and aggregate markdown summary blocks from test logs
  • Integrates the log collection script into the GitHub Actions workflow to display summaries in the workflow step summary
  • Adds the tabulate package dependency (required by pandas to_markdown() method)

Reviewed changes

Copilot reviewed 28 out of 28 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
op_tests/test_topk_plain.py Refactored imports and converted summary output to markdown format
op_tests/test_topk_per_row.py Converted two summary outputs (prefill and decode) to markdown format
op_tests/test_smoothquant.py Converted three summary outputs to markdown format
op_tests/test_sample.py Converted summary output to markdown format
op_tests/test_quant.py Converted summary output to markdown format
op_tests/test_pa_ps.py Converted summary output to markdown format
op_tests/test_pa_mtp.py Converted summary output to markdown format
op_tests/test_pa.py Converted summary output to markdown format
op_tests/test_moe_sorting_mxfp4.py Converted two stage summary outputs to markdown format
op_tests/test_moe_sorting.py Converted summary output to markdown format
op_tests/test_moe_dp_share_expert.py Converted summary output to markdown format
op_tests/test_moe_2stage.py Converted summary output to markdown format
op_tests/test_moeTopkSoftmax.py Converted three summary outputs to markdown format
op_tests/test_mla_sparse.py Converted summary output to markdown format
op_tests/test_mla_persistent.py Converted summary output to markdown format
op_tests/test_mla.py Converted summary output to markdown format
op_tests/test_kvcache.py Converted summary output to markdown format
op_tests/test_indexer_k_quant_and_cache.py Converted summary output to markdown format
op_tests/test_gemm_a8w8_blockscale.py Converted summary output to markdown format
op_tests/test_gemm_a8w8.py Converted summary output to markdown format
op_tests/test_gemm_a4w4.py Converted summary output to markdown format
op_tests/test_gemm_a16w16.py Converted summary output to markdown format
op_tests/test_deepgemm.py Converted summary output to markdown format
op_tests/test_concat_cache_mla.py Converted two summary outputs to markdown format
op_tests/test_activation.py Converted two summary outputs to markdown format
.github/workflows/aiter-test.yaml Added log collection step to extract and display markdown summaries in workflow output
.github/scripts/collect_logs.py New script that parses log files to extract markdown-formatted summary tables
.github/scripts/build_aiter_triton.sh Added tabulate package installation (required for pandas markdown conversion)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gyohuangxin gyohuangxin merged commit f4a69e2 into main Jan 1, 2026
21 checks passed
@gyohuangxin gyohuangxin deleted the optimize_test_summary branch January 1, 2026 06:19
farlukas pushed a commit that referenced this pull request Jan 5, 2026
* CI: Optimize and collect op_tests summaries

* fix

* Update op_tests/test_topk_plain.py

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* convert to makrdown

* Add collect_logs.py

* Update op_tests/test_smoothquant.py

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

---------

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants