PR583 hot fix#595
Open
aris134 wants to merge 1 commit into
Open
Conversation
alextmagro
approved these changes
May 21, 2026
Micky774
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
PR583 resulted in some jax test failures.
The tuned HIP RMSNorm kernel can introduce small numerical jitter compared to the general kernel path. For MXFP8, these tiny differences can shift the selected scaling factor by one step, which in turn can double or halve the quantized data representation and cause bitwise comparisons to fail despite equivalent numerical behavior.
This hotfix disables precise/bitwise comparison for HIP MXFP8 test coverage while preserving the existing numerical correctness checks.
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: