Skip to content

PR583 hot fix#595

Open
aris134 wants to merge 1 commit into
devfrom
amartin/hotfix-pr583
Open

PR583 hot fix#595
aris134 wants to merge 1 commit into
devfrom
amartin/hotfix-pr583

Conversation

@aris134
Copy link
Copy Markdown
Contributor

@aris134 aris134 commented May 21, 2026

Description

PR583 resulted in some jax test failures.

The tuned HIP RMSNorm kernel can introduce small numerical jitter compared to the general kernel path. For MXFP8, these tiny differences can shift the selected scaling factor by one step, which in turn can double or halve the quantized data representation and cause bitwise comparisons to fail despite equivalent numerical behavior.

This hotfix disables precise/bitwise comparison for HIP MXFP8 test coverage while preserving the existing numerical correctness checks.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@aris134 aris134 added ci-level 1 CI test level 1 ci-level 3 CI test level 3 and removed ci-level 1 CI test level 1 labels May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-level 3 CI test level 3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants