RMS Norm Optimization#583
Open
aris134 wants to merge 9 commits into
Open
Conversation
… missing configs for layer norm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (16527)
RMSNorm falls back to general kernel implementation on several DeepSeek and Qwen shapes, causing poor performance. These shapes have been registered with the tuned kernel cache, and a performance benchmark for RMSNorm has been added.
Additionally, a fallback warning is printed the first time at which a tuned config is not found for a requested kernel. For example:
E2E TFLOPS/s/GPU for proxy models (Previous -> Current with RMSNorm tuning) :
Qwen:
bf16: 369.4 -> 374.7
fp8: 352.1 ->358.2
Deepseek:
bf16: 501.4 -> 529.4
fp8: 463.9 -> 511.4
Also added matching tuned configs for LayerNorm.
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: