CK Tile Group GEMM gfx1250#576
Open
aris134 wants to merge 3 commits into
Open
Conversation
ipanfilo
requested changes
May 7, 2026
| // Currently only support cutlass group gemm on Hopper Arch | ||
| if (!(is_hopper && use_cutlass)) { | ||
| //if (!(is_hopper && use_cutlass)) { | ||
| if (!use_cutlass) { |
| using type = TileCfg_256x256x64_WMMA; | ||
| }; | ||
|
|
||
| template <GPUArch Arch> |
Collaborator
There was a problem hiding this comment.
Why does it need template over reguler if-else or switch-case?
Contributor
Author
There was a problem hiding this comment.
The template is needed because the arch selection affects CK kernel template instantiation, not just runtime control flow. GPUArch must be a compile-time value so if constexpr can prune unsupported tile/kernel combinations for a given architecture. In this case, it prevents the MFMA configs from being instantiated for gfx1250.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Extend the present CK tile grouped GEMM (F16/F8) implementation for compatibility with gfx1250.
NOTE: I realized this PR also depends on the newer CK module revision provided for the grouped GEMM work. Since the upcoming MXFP8 PR will have the same dependency, I plan to split the CK module update into a separate prerequisite PR against
gfx1250, then retarget/rebase this PR on top of that branch. This should avoid duplicating the CK update across both feature PRs.Fixes #16286
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: