Skip to content

CK Tile Group GEMM gfx1250#576

Open
aris134 wants to merge 3 commits into
gfx1250from
amartin/ck-group-gemm-gfx1250-clean
Open

CK Tile Group GEMM gfx1250#576
aris134 wants to merge 3 commits into
gfx1250from
amartin/ck-group-gemm-gfx1250-clean

Conversation

@aris134
Copy link
Copy Markdown
Contributor

@aris134 aris134 commented May 6, 2026

Description

Extend the present CK tile grouped GEMM (F16/F8) implementation for compatibility with gfx1250.

NOTE: I realized this PR also depends on the newer CK module revision provided for the grouped GEMM work. Since the upcoming MXFP8 PR will have the same dependency, I plan to split the CK module update into a separate prerequisite PR against gfx1250, then retarget/rebase this PR on top of that branch. This should avoid duplicating the CK update across both feature PRs.

Fixes #16286

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@aris134 aris134 requested a review from wenchenvincent as a code owner May 6, 2026 17:54
@aris134 aris134 added the ci-level 1 CI test level 1 label May 6, 2026
@aris134 aris134 requested review from ipanfilo and wangye805 as code owners May 6, 2026 17:54
@aris134 aris134 assigned aris134 and unassigned matthiasdiener and aris134 May 6, 2026
@aris134 aris134 requested a review from matthiasdiener May 6, 2026 17:55
@aris134 aris134 changed the title CK Tile Group GEMM GFX1250 CK Tile Group GEMM gfx1250 May 6, 2026
// Currently only support cutlass group gemm on Hopper Arch
if (!(is_hopper && use_cutlass)) {
//if (!(is_hopper && use_cutlass)) {
if (!use_cutlass) {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is CUDA path

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted in 752e0d3

using type = TileCfg_256x256x64_WMMA;
};

template <GPUArch Arch>
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it need template over reguler if-else or switch-case?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template is needed because the arch selection affects CK kernel template instantiation, not just runtime control flow. GPUArch must be a compile-time value so if constexpr can prune unsupported tile/kernel combinations for a given architecture. In this case, it prevents the MFMA configs from being instantiated for gfx1250.

@aris134 aris134 requested a review from ipanfilo May 11, 2026 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-level 1 CI test level 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants