Skip to content

gfx1250 swizzle_xor changes for FP4#571

Open
matthiasdiener wants to merge 10 commits intodevfrom
mdiener/swizzle_xor-1250
Open

gfx1250 swizzle_xor changes for FP4#571
matthiasdiener wants to merge 10 commits intodevfrom
mdiener/swizzle_xor-1250

Conversation

@matthiasdiener
Copy link
Copy Markdown
Contributor

@matthiasdiener matthiasdiener commented May 1, 2026

Description

Allow building the swizzle instructions on gfx1250.
No performance difference on gfx950.

Only d714038 is a functional change.

transformer_engine/common/cast/mxfp4/cast_transpose_mxfp4_shuffled.cuh was inadvertently merged with Windows (CRLF) line endings, fixed in 76ca4b1.

Type of change

  • Documentation change (change only to the documentation, either a fix or a new content)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Infra/Build change
  • Code refactoring

Changes

Please list the changes introduced in this PR:

  • Change A
  • Change B

Checklist:

  • I have read and followed the contributing guidelines
  • The functionality is complete
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@matthiasdiener matthiasdiener requested a review from sudhu2k May 1, 2026 18:44
@matthiasdiener matthiasdiener self-assigned this May 1, 2026
@matthiasdiener matthiasdiener added the ci-level 1 CI test level 1 label May 1, 2026
@matthiasdiener matthiasdiener marked this pull request as ready for review May 4, 2026 04:05
Comment thread transformer_engine/common/hadamard_transform/wht16.cuh Outdated
Comment thread transformer_engine/common/hadamard_transform/hadamard_transform.cu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci-level 1 CI test level 1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants