[CI] Unpin exact triton wheel hash to fix install failure#600
Open
coderfeli wants to merge 1 commit into
Open
Conversation
The CI pinned `triton==3.7.0+amd.rocm7.2.0.gitd1660454`, but AMD overwrites the build-hash suffix whenever they publish a new wheel for a given ROCm version (gitd1660454 -> gitd0d77a509), so the pinned wheel disappears from the index and `pip install` fails before tests can run. Install `triton` unpinned from the same ROCm 7.2.0 index and rely on the existing `>=3.6.0` assertion (next line) as the version floor, mirroring aiter's install_triton.sh, which never pins the volatile `.gitXXXX` hash. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI installs triton with an exact build-hash pin:
AMD overwrites the
.gitXXXXXXXbuild-hash suffix whenever they publish a new wheel for a given ROCm version (gitd1660454→gitd0d77a509). When that happens the pinned wheel vanishes from the index, sopip installfails and the test job dies before running anything. This pin predates #597 — it's repo-history legacy living onmain, so every branch inherits the breakage.Fix
Install
tritonunpinned from the same ROCm 7.2.0 index, and let the already-present>=3.6.0assertion on the next line act as the version floor:This mirrors aiter's
install_triton.sh, which never pins the volatile build hash — it installstritonfrom the index and verifies>=3.6.0.Scope
One line in
.github/workflows/flydsl.yaml. Fixes CI repo-wide; other open branches (e.g. #597) pick it up on their next rebase ontomain.🤖 Generated with Claude Code