Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The FlyDSL wheel build pipeline was hardcoded to only build for Python 3.10 and 3.12. This PR generalizes the build system to accept an arbitrary list of Python versions, enabling support for Python 3.13 (and any future versions) without requiring further code changes. This unblocks users and downstream consumers who have adopted Python 3.13.
Technical Details
3 files changed across CI workflows and the build script:
.github/workflows/build-whl.yamlpython_versionsworkflow input (default:"3.10 3.12") so callers can specify which Python versions to build wheels for.python3.12install step with a loop that installs each requested Python version from the deadsnakes PPA (skipping versions already present in the Docker image).PYTHON_VERSIONSenv var into the Docker build container.fly-opt, instead of hardcodingbuild_py312..github/workflows/ci.yamlpython_versionsinput (default:"3.10 3.12") and forwards it to thebuild-whlworkflow.scripts/build_wheels.shPY310_BIN/PY312_BIN,VENV_310/VENV_312, andFLY_BUILD_DIR_310/FLY_BUILD_DIR_312variables with a singlePYTHON_VERSIONSenvironment variable.ensure_python_bins()to loop overPYTHON_VERSIONSdynamically.main()build loop to derivepy_tag(e.g.,cp313),pybin,venvpath, andbuild_dirfrom each version string.PYTHON_VERSIONSknob.To build with Python 3.13, callers simply pass
python_versions: "3.10 3.12 3.13"to the workflow.Test Plan
ci.yamlworkflow withpython_versions: "3.10 3.12"(default) and verify wheels are built for both versions.ci.yamlworkflow withpython_versions: "3.10 3.12 3.13"and verify acp313wheel is produced.fly-optbinary is correctly copied from the first version's build directory.Test Result
Pending
Submission Checklist