Add support to setting known_block_size#267
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an optional known_block_size plumbing path from the @kernel decorator through KernelFunction to the emitted gpu.func, enabling AMDGPU backends to derive max_flat_workgroup_size for larger workgroups (e.g., 512 threads).
Changes:
- Add
known_block_sizeparameter tocreate_gpu_func()and forward it togpu.GPUFuncOp. - Extend
KernelFunction/@kerneldecorator API to accept and storeknown_block_size. - Pass stored
known_block_sizewhen emitting the kernelgpu.funcand document usage in the decorator docstring.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
@ruanjm CI failed. |
ruanjm
force-pushed
the
jruan/known_block_size
branch
from
42d953a to
5af360e
Compare
Contributor
Author
fixed. |
coderfeli
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for for supporting workgroup size 512. The AMDGPU backend defaults to
max_flat_workgroup_size = 256.