Remove Triton build stage from Dockerfile#1035
Draft
gyohuangxin wants to merge 1 commit into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the ATOM base image Docker build by removing the dedicated Triton parallel build stage and the final merge step that copied Triton artifacts from that removed stage.
Changes:
- Remove the
build_tritonstage (clone/build/install Triton from source) fromdocker/Dockerfile. - Remove the final-stage
RUN --mount=from=build_triton ...copy step and renumber subsequent stages/update the parallel-build diagram.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
359
to
361
| # Aiter: copy compiled source tree + re-register editable install | ||
| # (pip install -e creates egg-link automatically, no need to COPY them) | ||
| COPY --from=build_aiter /app/aiter-test /app/aiter-test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
git diff --check -- docker/Dockerfiledocker/Dockerfile.