Gfx1250 bringup moe#1007
Draft
yadaish wants to merge 3 commits into
Draft
Conversation
Route HIP kernels that fault/hang on gfx1250 to their AITER Triton or torch-native equivalents at every call site: - layernorm: rmsnorm2d_fwd / rmsnorm2d_fwd_with_add -> Triton rmsnorm - sampler: mixed_sample_outer_exponential -> torch greedy argmax (temp=0 bring-up) - topK: biased_grouped_topk (module_moe_asm) -> biased_grouped_topk_torch - attention_mla: gfx1250 routing Also fold structural HF fields (num_hidden_layers, first_k_dense_replace, num_nextn_predict_layers) into the compile-cache key so a graph compiled for one model depth isn't silently reused for another shape. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Route gfx1250 MoE scale prep through the grouped a8w4 kernel's _grouped_a8w4_prepare_scale_batch preshuffle, keeping the original shuffle_scale path for all other archs. gfx1250 only supports the non-interleaved (gate|up separated) scale layout, so raise if ATOM_MOE_GU_ITLV is set on that arch. Rename the gfx12 triton auto-enable to is_gfx1250; ATOM_USE_TRITON_MOE override is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Technical Details
Test Plan
Test Result
Submission Checklist