[Fix] Fix sparse_attn_v4_paged_prefill for MI308#1003
Open
yitingw1 wants to merge 4 commits into
Open
Conversation
valarLip
approved these changes
Jun 1, 2026
valarLip
requested changes
Jun 1, 2026
| attn_sink, | ||
| softmax_scale, | ||
| ) | ||
| except RuntimeError: |
Collaborator
There was a problem hiding this comment.
we should fallback to triton impl once we get runtime error…
Author
There was a problem hiding this comment.
Yes, we will fallback to triton impl (line 389) once we get runtime error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Fix DeepSeek V4 op
sparse_attn_v4_paged_prefillfor MI308.In
sparse_attn_v4_paged_prefill,pa_sparse_prefill_opusrequires gfx950. When running on gfx942, fallback to Triton version_sparse_attn_v4_paged_prefill_triton.Submission Checklist