[AIRADSW-468] Fix Windows hang by draining the output pipe before waiting#4865
Open
ivarusic-amd wants to merge 10 commits into
Open
[AIRADSW-468] Fix Windows hang by draining the output pipe before waiting#4865ivarusic-amd wants to merge 10 commits into
ivarusic-amd wants to merge 10 commits into
Conversation
apwojcik
approved these changes
May 8, 2026
pfultz2
approved these changes
May 8, 2026
Collaborator
|
How do you want to handle the warning? Empty While Loop. Without something the code will hold the CPU in a tight loop |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributor
Author
|
@causten I change it, can you take a look. Thanks |
Regressions detected 🔴 |
|
…to fix_win_hang
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Multiple models hanging on migraphx-driver compile step WINDOWS.
Technical Details
When migraphx-hiprtc-driver produced enough stdout/stderr to fill the Windows pipe buffer, the parent process would deadlock: child blocked writing to a full pipe, parent blocked in WaitForSingleObject waiting for the child to exit.
Fixed by draining the output pipe after closing stdin and before WaitForSingleObject
Linux should not be affected.
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable