Add measurement of overall compile time to migraphx-driver#4863
Open
apwojcik wants to merge 6 commits into
Open
Add measurement of overall compile time to migraphx-driver#4863apwojcik wants to merge 6 commits into
migraphx-driver#4863apwojcik wants to merge 6 commits into
Conversation
pfultz2
requested changes
May 8, 2026
| << std::chrono::duration_cast<std::chrono::milliseconds>(e - s).count() | ||
| << "ms"; | ||
| } | ||
| }; |
Collaborator
There was a problem hiding this comment.
We already have a timer class, you should reuse that.
pfultz2
reviewed
May 11, 2026
| ap(to_int8, {"--int8"}, ap.help("Quantize for int8"), ap.set_value(true)); | ||
| ap(to_fp8, {"--fp8"}, ap.help("Quantize for fp8"), ap.set_value(true)); | ||
| ap(to_int4, {"--int4-weights"}, ap.help("Quantize weights for int4"), ap.set_value(true)); | ||
| ap(report_time, {"--time"}, ap.help("Report compilation time"), ap.set_value(true)); |
Collaborator
There was a problem hiding this comment.
The flag should be --report-compile-time a --time is just too ambiguous.
Although I think this should just be enabled by default.
| bool to_fp8 = false; | ||
| bool to_int8 = false; | ||
| bool to_int4 = false; | ||
| bool report_time = false; |
Collaborator
There was a problem hiding this comment.
This should be named repport_compile_time.
Co-authored-by: Paul Fultz II <paul.fultz@amd.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change has been migrated from the uai-develop branch.
The PR adds a command-line option to
migraphx-driverto measure overall compile time.