Clean up the #include dependencies for the instruction_ref#4860
Open
apwojcik wants to merge 6 commits into
Open
Clean up the #include dependencies for the instruction_ref#4860apwojcik wants to merge 6 commits into
apwojcik wants to merge 6 commits into
Conversation
pfultz2
requested changes
May 8, 2026
| inline namespace MIGRAPHX_INLINE_NS { | ||
|
|
||
| struct module_pass_manager; | ||
| struct instruction; |
Collaborator
There was a problem hiding this comment.
We dont use instruction or instruction_ref in this file, so there is no reason to forward declare it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The change has been migrated from the uai-develop branch.
The PRs relax the #include dependencies for the
instruction_refstruct.