disable fuse_horizontal for dynamic shapes#4853
Open
shivadbhavsar wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Disables the fuse_horizontal compiler pass in GPU compilation when “full dynamic” mode is enabled, to avoid failures caused by fuse_horizontal calling shape.lens() (which throws for dynamic shapes). This aligns the GPU pass pipeline with current dynamic-shape limitations while symbolic-shape support is reworked (per #4844).
Changes:
- Gate
fuse_horizontal{}behindenable_pass(disabled(MIGRAPHX_ENABLE_FULL_DYNAMIC{}), ...)in the GPU target pass list.
| layout_convolution{.channels_last = enabled(MIGRAPHX_ENABLE_NHWC{})}, | ||
| dead_code_elimination{}, | ||
| fuse_horizontal{}, | ||
| enable_pass(disabled(MIGRAPHX_ENABLE_FULL_DYNAMIC{}), fuse_horizontal{}), |
| layout_convolution{.channels_last = enabled(MIGRAPHX_ENABLE_NHWC{})}, | ||
| dead_code_elimination{}, | ||
| fuse_horizontal{}, | ||
| enable_pass(disabled(MIGRAPHX_ENABLE_FULL_DYNAMIC{}), fuse_horizontal{}), |
CharlieL7
approved these changes
May 7, 2026
kahmed10
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The fuse_horizontal relies on shape.lens() which is not supported for dynamic shapes currently. We will rework this logic with symbolic shapes before re-enabling.
Technical Details
#4844
Changelog Category
Add a
CHANGELOG.mdentry for any option other thanNot Applicable