Review of the test framework in conftest.py #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
an attribute of class AutoPatchCaller
methods and subclasses of class AutoPatchCaller into classes and functions at module level. This avoids passing instances of AutoPatchCaller into the child process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thorough review of class
AutoPatchCallerthat implements the test framework. Move large parts of this class to global module level. This way the child process that invokes theauto-patch.pyscript for the tests inherits the stuff, so we avoid passing an instance ofAutoPatchCallerinto the child process. This adheres to the “Better to inherit than pickle/unpickle” principle from the multiprocessing programming guidelines.Close #16.