Really Tall Order of Stress (RTOS) for travis; VCU#5
Open
tmb5932 wants to merge 125 commits into
Open
Conversation
…fy EVT-core, gonna need to make a branch there for stuff to actually work. CMake is having issues finding tx_api.h, which I thought I had resolved but apparently it is not happy about it still.
…ad to do anything.
…nd cleaned up constructor in CPP.
…mespacing is not necessary, but it builds now and it wasn't before).
…ed up how changes are alerted.
…first byte is msg identifier)
DannyCato
approved these changes
May 25, 2026
There was a problem hiding this comment.
I was lookinf at this PR for an hour. My eyes have completely glazed over at this point
Approved since the only thing I could see was the couple missing comments. Functionality seemed fine when we tested it, but we will need to do real testing on the bike soon
|
|
||
| //Set based off of ucState. | ||
| io::GPIO& canSelfTestGPIO; | ||
| typedef union { |
| }; | ||
| } LVSSPowerState_t; | ||
|
|
||
| typedef union { |
| UC_State stateEnum; | ||
| }; | ||
|
|
||
| typedef union { |
| HealthFlags_t healthFlags = {0}; | ||
|
|
||
| /// the gpios | ||
| MCuC_GPIO gpios; |
| bool forwardEnable = (message.getPayload()[2] & 0b10000000) != 0; | ||
| return forwardEnable; | ||
| void PowertrainCAN::setMCAll(int16_t torque, int16_t speed, int16_t direction, bool inverterEn, bool inverterDC, | ||
| int16_t speedModeEn, int16_t rollingCounter, int16_t torqueLimit) { |
There was a problem hiding this comment.
Why not just intake a struct reference to set mcCommandPayload instead of a bunch of struct parameters?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok, so mcuc is effectively done, aside from minor adjustments. Powertrain can and canOpen work (for all things testable), some are still waiting for other end to be finished (HIB, BMS, etc), but example implementation is done.