Use new BiocGenerics::transform() with new signature#281
Open
hpages wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @mikejiang,
We've recently added the
transform()generic to BiocGenerics. See Bioconductor/BiocGenerics@54579afNote that this new generic uses the more conventional
tranform(x, ...)interface rather thantransform(_data, ...).This PR makes the necessary adjustments in flowCore to use this new generic instead of defining its own.
PRs for ncdfFlow, flowWorkspace, and ggcyto also coming in the next minutes.
Thanks,
H.
PS: I didn't include the full re-oxygenation in the PR because it touches too many files but it would not hurt to do it at some point.