Skip to content

Conversation

@efrain-mejia
Copy link

Closes #29.

paulocampez and others added 22 commits March 18, 2025 13:07
…on-update

Feat/dependencies version update
fix: $count & $filter with null value
…-12-PR

replicating change request from issue 12 PR
…rver/main' into 29-migrate-reference-server-to-mongodb
build.gradle Outdated
id 'maven-publish'
id 'java-library' // For creating reusable libraries
id 'war'
id "de.undercouch.download" version "5.4.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider removing the dependency and using the gradle commands to deal with this - either by executing curl or wget at the shell or using code in the gradle task to manage it.

build.gradle Outdated
url = uri('https://repo.maven.apache.org/maven2/')
java {
toolchain {
languageVersion = JavaLanguageVersion.of(8)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should try to update to at least 11. But 17+ is preferred.

build.gradle Outdated

group = 'org.reso'
version = '1.0'
description = 'RESOservice'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should change to WebApiReferenceServer and bump the version to 2.0.

build.gradle Outdated

// Ensure compatibility with Java 8
java {
sourceCompatibility = JavaVersion.VERSION_1_8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should try and upgrade to at least 11.

version: "3.8"
services:
builder:
image: ubuntu:20.04
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually we use Debian in production over Ubuntu since it's smaller and more stable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gradlew Outdated
APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit

APP_NAME="reso-web-api-reference-server"
# This is normally unused
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can remove any commented out lines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migrate RESO Web API Reference Server to MongoDB

5 participants