-
Notifications
You must be signed in to change notification settings - Fork 10
#29: Migrate RESO Web API Reference Server to MongoDB #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
#29: Migrate RESO Web API Reference Server to MongoDB #34
Conversation
Commit Commit Reorganize Build Configuration, Add Debug Option
Reorganize Build Config, Add Debugging
saveEnumDataMongo
Feature/expand refactor
dynamic lookup script
Migrate Build Scripts
copy data from DB script
…on-update Feat/dependencies version update
fix: $count & $filter with null value
fix: QA fixes
…-12-PR replicating change request from issue 12 PR
…rver/main' into 29-migrate-reference-server-to-mongodb
build.gradle
Outdated
| id 'maven-publish' | ||
| id 'java-library' // For creating reusable libraries | ||
| id 'war' | ||
| id "de.undercouch.download" version "5.4.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider removing the dependency and using the gradle commands to deal with this - either by executing curl or wget at the shell or using code in the gradle task to manage it.
build.gradle
Outdated
| url = uri('https://repo.maven.apache.org/maven2/') | ||
| java { | ||
| toolchain { | ||
| languageVersion = JavaLanguageVersion.of(8) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should try to update to at least 11. But 17+ is preferred.
build.gradle
Outdated
|
|
||
| group = 'org.reso' | ||
| version = '1.0' | ||
| description = 'RESOservice' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should change to WebApiReferenceServer and bump the version to 2.0.
build.gradle
Outdated
|
|
||
| // Ensure compatibility with Java 8 | ||
| java { | ||
| sourceCompatibility = JavaVersion.VERSION_1_8 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should try and upgrade to at least 11.
docker-compose.builder.yml
Outdated
| version: "3.8" | ||
| services: | ||
| builder: | ||
| image: ubuntu:20.04 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually we use Debian in production over Ubuntu since it's smaller and more stable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See this file for updated references.
https://github.com/RESOStandards/reso-certification-utils/blob/v3.0.0/Dockerfile
gradlew
Outdated
| APP_HOME=$( cd "${APP_HOME:-./}" && pwd -P ) || exit | ||
|
|
||
| APP_NAME="reso-web-api-reference-server" | ||
| # This is normally unused |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can remove any commented out lines.
tests workflow for main PR
java version update & debian
Closes #29.