Skip to content

Conversation

@snedamle
Copy link
Contributor

No description provided.

@snedamle snedamle requested a review from rusheb August 25, 2021 09:54
screen.
This sample can be extended further to tweak the model parameters, based off the evaluation result. The clients can send
more training data to better train the model.
The clients can further send out some input data, and the model can predict if the input data tumor is malignant or benign.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this actually possible with the current version of the sample? I thought you could only use it for training and evaluating a model.

Haven't looked at this in a while so apologies if I'm mistaken

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope this says that - "This sample can be extended further to...".

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh right, I read this as "This sample can be extended further to tweak the model parameters, based off the evaluation result." ... and then the following sentences you can already do. Maybe it would be clearer to phrase it like

This sample can be extended in a number of ways:

  • ...
  • ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines +62 to +63
This sample can be extended in a number of ways:
* The clients can tweak the model parameters, based off the evaluation result. The clients can then send
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This sample can be extended in a number of ways:
* The clients can tweak the model parameters, based off the evaluation result. The clients can then send
This sample can be extended in a number of ways:
* Enable the clients to tweak the model parameters, based off the evaluation result. The clients could then send

* The clients can tweak the model parameters, based off the evaluation result. The clients can then send
more training data to better train the model.
The clients can further send out some input data, and the model can predict if the input data tumor is malignant or benign.
* The clients can further send out some input data, and the model can predict if the input data tumor is malignant or benign.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* The clients can further send out some input data, and the model can predict if the input data tumor is malignant or benign.
* Enable the clients to send some input data once the model has been trained, to predict whether a tumor is malignant or benign.

@CLAassistant
Copy link

CLAassistant commented Aug 31, 2022

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants