refactor: Pass launch options via object #760
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Requesting review from @Alystrasz cause it's been a while since I last wrote TypeScript and I feel like I'm using rather primitive patterns that probably have a smarter way of doing things ^^" |
Currently object only has a single member for bypassing all checks. In the future this would be split up into multiple members for different checks to bypass as well as other options.
GeckoEidechse
force-pushed
the
refactor/pass-launch-options-object
branch
from
c499094 to
b00fbee
Compare
Alystrasz
requested changes
Jan 21, 2024
github-actions
bot
added
the
merge conflicts
Member
Author
|
This should be ready for re-review now ^^ |
GeckoEidechse
commented
Feb 12, 2024
Member
Author
GeckoEidechse
left a comment
GeckoEidechse
left a comment
There was a problem hiding this comment.
In quick testing on Linux I can confirm that the changed front-end logic for launching via Steam and with bypassing checks still works.
Cannot test the standard play button atm though...
github-actions
bot
removed
the
merge conflicts
Alystrasz
approved these changes
Feb 21, 2024
Collaborator
Alystrasz
left a comment
Alystrasz
left a comment
There was a problem hiding this comment.
Comments addressed, confirmed working in testing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently object only has a single member for bypassing all checks. In the future this would be split up into multiple members for different checks to bypass as well as other options.
Then I can get rid of the
launchGameViaSteamfunction and just make it some bool passed to backend. In fact, the backend has already been adjusted for this ^^The goal is to have something like this, where different options for how to launch Northstar could be set.
Maybe even extended with some degree of launch args, primarily focused on dev stuff, so more towards #449 and less #301 (although the same object could be extended to pass launch args ^^
Requires:
Part of: