Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/Service/GlobalSettingsService.php
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ public function setGlobalSettings(GlobalSettings $settings) : void {
foreach ($this->getProperties($settings) as $prop) {
$key = $prop->getName();
$value = $settings->$key;
$this->config->setValueString(Application::APP_NAME, $key, $value);
$this->config->setValueString(Application::APP_NAME, $key, (string)($value ?? ''));
}
}

Expand Down
23 changes: 23 additions & 0 deletions tests/Unit/Service/GlobalSettingsServiceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,29 @@ public function testGetSettings_ReturnsCorrectSettings() {
$this->assertEquals(30, $settings->timeout);
}

public function testSetSettings_ConvertsIntegerValuesToString() {
$settings = new GlobalSettings();
$settings->processorCount = 4;
$settings->timeout = 60;

$this->config->expects($this->any())
->method('setValueString')
->willReturnCallback(
function (string $appName, string $key, string $value) {
if ($key === 'processorCount') {
$this->assertEquals('4', $value);
} elseif ($key === 'timeout') {
$this->assertEquals('60', $value);
} else {
$this->fail("Unexpected key: $key");
}
return true;
}
);

$this->globalSettingsService->setGlobalSettings($settings);
}

public function testSetSettings_CallsConfigSetAppValue() {
$settings = new GlobalSettings();
$settings->processorCount = '2';
Expand Down
Loading