Replace window with globalThis in appGlobals.js #349
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated package.json to replace rspack commands with rsbuild equivalents. - Removed rspack.config.js and added rsbuild.config.js with new configuration. - Adjusted linting scripts to ensure proper file matching. - Updated dependencies to align with rsbuild requirements.
Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor build configuration to use rsbuild
Replace window with globalThis in appGlobals.js
Jan 10, 2026
Contributor
|
@copilot fix the test error by applying an composer deps update to get the most recent Nextcloud function signatures |
Co-authored-by: R0Wi <19730957+R0Wi@users.noreply.github.com>
Contributor
Author
Updated composer dependencies to get the latest Nextcloud function signatures. The |
Copilot stopped work on behalf of
R0Wi due to an error
January 10, 2026 10:41
R0Wi
force-pushed
the
fix/update-npm-deps
branch
from
3b8fa83 to
ce05b08
Compare
Contributor
|
Moved to #344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The test failures were caused by a type incompatibility in Nextcloud's OCMDiscoveryService class where the return type didn't match the updated interface signature in the newer version of the
nextcloud/ocppackage. Updated the composer.lock by runningcomposer update nextcloud/ocp, which upgraded the package to include the latest function signatures that are compatible with the Nextcloud server code.💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.