Skip to content

feat: add Each component as experimental and update documentation#8474

Merged
wmertens merged 2 commits intobuild/v2from
v2-each-as-experimental
Mar 26, 2026
Merged

feat: add Each component as experimental and update documentation#8474
wmertens merged 2 commits intobuild/v2from
v2-each-as-experimental

Conversation

@Varixo
Copy link
Copy Markdown
Member

@Varixo Varixo commented Mar 24, 2026

No description provided.

@Varixo Varixo self-assigned this Mar 24, 2026
@Varixo Varixo requested review from a team as code owners March 24, 2026 21:15
@Varixo Varixo added the V2 label Mar 24, 2026
@changeset-bot
Copy link
Copy Markdown

changeset-bot bot commented Mar 24, 2026

⚠️ No Changeset found

Latest commit: 0a83436

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@maiieul maiieul moved this from Backlog to Waiting For Review in Qwik Development Mar 24, 2026
@pkg-pr-new
Copy link
Copy Markdown

pkg-pr-new bot commented Mar 24, 2026

Open in StackBlitz

npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/core@8474
npm i https://pkg.pr.new/QwikDev/qwik/@qwik.dev/router@8474
npm i https://pkg.pr.new/QwikDev/qwik/eslint-plugin-qwik@8474
npm i https://pkg.pr.new/QwikDev/qwik/create-qwik@8474

commit: 131db8d

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 24, 2026

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview a07e6bd

Comment on lines +241 to +249
const experimentalDefines =
opts.target === 'lib'
? {}
: Object.fromEntries(
Object.values(ExperimentalFeatures).map((feature) => [
`__EXPERIMENTAL__.${feature}`,
JSON.stringify(!!opts.experimental?.[feature]),
])
);
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't we already have this in plugin.ts?

@Varixo
Copy link
Copy Markdown
Member Author

Varixo commented Mar 25, 2026

closing this in favor of #8482

@Varixo Varixo closed this Mar 25, 2026
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Mar 25, 2026
@wmertens wmertens reopened this Mar 26, 2026
@maiieul maiieul moved this from Done to Waiting For Review in Qwik Development Mar 26, 2026
@wmertens wmertens force-pushed the v2-each-as-experimental branch from 131db8d to a07e6bd Compare March 26, 2026 10:57
Copy link
Copy Markdown
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens enabled auto-merge March 26, 2026 11:00
@wmertens wmertens force-pushed the v2-each-as-experimental branch 2 times, most recently from b599cd5 to 50efc4e Compare March 26, 2026 13:15
@wmertens wmertens force-pushed the v2-each-as-experimental branch from 50efc4e to 0a83436 Compare March 26, 2026 14:13
@wmertens wmertens merged commit 4661327 into build/v2 Mar 26, 2026
24 checks passed
@wmertens wmertens deleted the v2-each-as-experimental branch March 26, 2026 14:29
@github-project-automation github-project-automation bot moved this from Waiting For Review to Done in Qwik Development Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants