Update Display Compatibility for EcoEnchants and Reforges#2346
Conversation
|
|
| <configuration> | ||
| <relocations> | ||
| <relocation> | ||
| <pattern>kotlin</pattern> |
There was a problem hiding this comment.
Is this required? Are you saying that ecoenchants isn't shading their kotlin dependency?
| <groupId>com.willfp</groupId> | ||
| <artifactId>Reforges</artifactId> | ||
| <version>${compat.reforges}</version> | ||
| <version>7.5.0</version> |
There was a problem hiding this comment.
Why did the version properties get removed instead of updating them in the main pom?
| previewItemStack = previewComponentPrePopulateEvent.getItemStack(); | ||
| Component previewComponent = plugin.text().of(p, "menu.preview", Component.text(previewItemStack.getAmount())).forLocale().clickEvent(ClickEvent.clickEvent(ClickEvent.Action.RUN_COMMAND, MsgUtil.fillArgs("/{0} {1} {2}", plugin.getMainCommand(), plugin.getCommandPrefix("silentpreview"), shop.getRuntimeRandomUniqueId().toString()))); | ||
| previewComponent = plugin.platform().setItemStackHoverEvent(previewComponent, shop.getItem()); | ||
| previewComponent = plugin.platform().setItemStackHoverEvent(previewComponent, previewItemStack); |
There was a problem hiding this comment.
Has this replacement been tested? I noticed your note stating you weren't sure if it's going to mess anything up or not...
| <groupId>com.willfp</groupId> | ||
| <artifactId>eco</artifactId> | ||
| <version>${compat.eco}</version> | ||
| <version>7.6.1</version> |
There was a problem hiding this comment.
Why did the version properties get removed instead of updating them in the main pom?
| <groupId>com.willfp</groupId> | ||
| <artifactId>eco</artifactId> | ||
| <version>${compat.eco}</version> | ||
| <version>7.6.1</version> |
There was a problem hiding this comment.
Why did the version properties get removed instead of updating them in the main pom?
| <dependency> | ||
| <groupId>com.willfp</groupId> | ||
| <artifactId>libreforge-loader</artifactId> | ||
| <version>5.4.2</version> |
There was a problem hiding this comment.
This should have a property added to the main project pom.
| <groupId>com.willfp</groupId> | ||
| <artifactId>EcoEnchants</artifactId> | ||
| <version>${compat.ecoenchants}</version> | ||
| <version>13.6.0</version> |
There was a problem hiding this comment.
Why did the version properties get removed instead of updating them in the main pom?
| <dependency> | ||
| <groupId>com.willfp</groupId> | ||
| <artifactId>libreforge-loader</artifactId> | ||
| <version>5.4.2</version> |
There was a problem hiding this comment.
This should have a property added to the main project pom.
3 participants
Summary
What does this PR do?
Type of Change
Basic Checks
Notes (optional)
Add anything important for reviewers:
Config Changes (if applicable)
Only fill this out if you touched config:
Breaking Changes (if applicable)
Related (optional)