Expand upon our API to improve ease-of-use for third-party addons.#2328
Draft
creatorfromhell wants to merge 24 commits into
Draft
Expand upon our API to improve ease-of-use for third-party addons.#2328creatorfromhell wants to merge 24 commits into
creatorfromhell wants to merge 24 commits into
Conversation
…on API methods to PriceLimiter to expose methods to get RuleSets applicable to an ItemStack, QUser/Sender and/or currency.
…ce, generic ShopPrice and ShopService interfaces, and restructure ShopMeta. Introduce ShopActionResult, ShopActionFailureReason, and tagging enhancements. Migrate and consolidate price and limiter logic.
Added a new ShopRequest interface to standardize shop request handling. ShopCreateRequest, ShopUpdateRequest, and ShopDeleteRequest classes now implement this interface. Adjusted package structures for better organization and updated related imports.
… manager versions.
…val methods for SimpleShopService
…that is a version of the Shop object. These are the final steps towards completing the API portion of the updates before wiring it together in the bukkit project.
…or shop components.
…re methods inside SimpleShopWorldAdapter.
…hopSignStorage to API project as this makes the most sense.
…range methods between meta and interaction to make more sense and update builders.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Please select the type of change this PR represents:
General Contribution Checklist
hikaribranch.Description of Changes
Clearly explain:
Example:
Configuration Changes (if applicable)
If this PR modifies config.yml or another configuration file or adds new configuration options:
WARNING:comments and mitigation guidance.If config changes were made, explain them:
Migration Notes (Required for breaking changes)
If this PR includes a breaking change:
Example:
Related Issues / References
Testing Notes
How was this tested?
Additional notes:
Changelog Entry
If this change is user-facing, provide a changelog entry, which also includes your name/online alias:
Maintainer Review Checklist (Internal)
Thank you for contributing to QuickShop-Hikari, it means a lot to us!