Skip to content

fix: Correct camera fit trigonometry #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
EstebenR wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix: Correct camera fit trigonometry #575

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
a192674
fix: Correct camera fit trigonometry
EstebenR Aug 2, 2025
d0ae601
Merge branch 'main' into patch-1
Quenty Aug 7, 2025
049ac1e
Merge branch 'main' into patch-1
Quenty Aug 7, 2025
aee9ba8
Merge branch 'main' into patch-1
EstebenR Aug 14, 2025
46d3451
Merge branch 'main' into patch-1
EstebenR Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/camera/src/Client/CameraUtils.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ end

--[=[
Use spherical bounding box to calculate how far back to move a camera
See: https://community.khronos.org/t/zoom-to-fit-screen/59857/12

@param size Vector3 -- Size of the bounding box
@param fovDeg number -- Field of view in degrees (vertical)
Expand All @@ -54,6 +53,13 @@ end
--[=[
Fits a sphere to the camera, computing how far back to zoom the camera from
the center of the sphere.
Camera (C), object center (B) and object edge (A) form a right angle triangle
where AB is the radius and BC is the distance from the center to the camera
A
| \
| \
B-----C
Distance is given by equation tan(halfFov)=AB/BC => BC = AB/tan(halfFov)

@param radius number -- Radius of the sphere
@param fovDeg number -- Field of view in degrees (vertical)
Expand All @@ -66,7 +72,7 @@ function CameraUtils.fitSphereToCamera(radius: number, fovDeg: number, aspectRat
halfFov = math.atan(aspectRatio * math.tan(halfFov))
end

return radius / math.sin(halfFov)
return radius / math.tan(halfFov)
end

--[=[
Expand Down