Do not count mine clears as a judgement#214
Open
WilliamQiufeng wants to merge 2 commits intoQuaver:masterfrom
Open
Do not count mine clears as a judgement#214WilliamQiufeng wants to merge 2 commits intoQuaver:masterfrom
WilliamQiufeng wants to merge 2 commits intoQuaver:masterfrom
Conversation
…h that the maximum score will be the maximum number of judgements minus the number of mines
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires https://github.com/Quaver/Quaver.Server.Client/pull/36
This PR aims to reduce situation where a player would gain accuracy due to excessive number of mines. This is achieved by making a mine clear (the player not pressing the mines) not count towards a marvelous. A mine hit will still count as a miss.
Update score calculation such that the maximum score will be the maximum number of judgements minus the number of mines.
The following figure will show the updates to score calculation. Might need further investigation on whether this is potentially breakable.
The above scores are set on a map with 12 normal notes, followed by a mine, and followed by a normal note.
When the mine is hit, the player gets a miss, breaking the combo and thus does not get the maximum score.
When the mine is cleared, the player will get no judgement, but full score may be given.
PS funny thing I got during development