Skip to content

Leaf Proof Count 7#106

Open
illuzen wants to merge 5 commits into
mainfrom
illuzen/leaf-count-7
Open

Leaf Proof Count 7#106
illuzen wants to merge 5 commits into
mainfrom
illuzen/leaf-count-7

Conversation

@illuzen
Copy link
Copy Markdown
Contributor

@illuzen illuzen commented May 26, 2026

also updated metadata to latest for chain

this needs to update to latest version of qp-zk-circuits


Note

High Risk
Large generated metadata and circuit-parameter changes can break installed binaries until bins regenerate and must match the deployed runtime; multisig/high-security API removals are breaking for older integrations.

Overview
This PR retargets wormhole/ZK circuit generation for 7 leaf proofs per batch (down from 16), aimed at lower peak memory on mobile, and bumps the CLI to qp-poseidon-core 2.0.2 while dropping the separate qp-poseidon dependency.

Circuit binaries: DEFAULT_NUM_LEAF_PROOFS is now 7 and is public for reward aggregation. Runtime is_ready() also treats cached generated-bins as stale when config.json’s num_leaf_proofs or the CLI version marker no longer match; build.rs only watches QP_NUM_LEAF_PROOFS for rebuilds. A clippy.sh script mirrors CI’s locked clippy invocation.

Chain metadata: quantus_subxt.rs is regenerated for the latest runtime—ZkTree pallet/API, zk_tree_root on block headers, wormhole events carrying leaf_index (Merkle proofs via RPC), removal of wormhole TransferProof storage, reversible-transfers guardian naming/storage (GuardianIndex, next_transaction_id), and multisig pallet changes (e.g. no approve_dissolve, bounded propose calls, SignerApproved event, MaxInnerCallWeight). The high-security CLI follows guardian_index; the multisig example prints proposal_nonce instead of active proposal count.

Note: Example text may still mention dissolve APIs that no longer exist on-chain until follow-up doc fixes.

Reviewed by Cursor Bugbot for commit a6d2324. Bugbot is set up for automated code reviews on this repo. Configure here.

Comment thread src/bins_consts.rs
Copy link
Copy Markdown
Contributor

@n13 n13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the bugbot issue - can just rename the binaries or version them

Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 2525b29. Configure here.

Comment thread build.rs Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants