fix seed phrase overflow and bugs with 12 word seed phrases #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Hm... Isn't it too small, looks kinda weird. What if we reveal it? will it be small also? or the same as previous |
Collaborator
Author
|
Its for the rare case of 12 word phrases 24 look exactly the same as before |
dewabisma
approved these changes
Jan 23, 2026
Collaborator
dewabisma
left a comment
dewabisma
left a comment
There was a problem hiding this comment.
Okay, so it's different case. Will be ideal if we can have same layout regardless of 12 or 24 but it's not so easy to do it good. LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
12 word seed phrase had a bug #88
Now it's working, the reveal button shows and no more overflow error.