Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addressing some final issues:
REVERSIBLE-F-01 — set_high_security
No exit path has been added. recover_funds still does not clear HighSecurityAccounts or GuardianIndex. The team documented this permanence as intentional, so we understand that the risk is accepted.
Added documentation that recover_funds should be callable in perpetuity
REVERSIBLE-F-03 — orphaned holds
recover_funds now skips failed releases instead of aborting, which prevents new orphaned holds from being created. However, holds that were already detached from PendingTransfer metadata still have no repair path. No force-release extrinsic was added. One possible improvement would be to add a root-gated force_release_hold(account, asset, amount) extrinsic that can release holds directly.
This seems to only be possible due to migration, which we are skipping for testnet, as it would add code that wouldn't run on mainnet.
The following informational findings remain unaddressed: TREASURY-O-03, TREASURY-O-04, RUNTIME-O-01
Addressed the first two, the third was already addressed in a previous PR.
Note
Low Risk
Low risk: changes are limited to additional event emission on already-handled mint failures and documentation/error cleanup, with no changes to successful reward or transfer execution paths.
Overview
Adds a new
TreasuryMintFailedevent inmining-rewardsand emits it whenever minting to the treasury fails (both in the normal treasury payout path and when falling back from a miner mint failure), making lost-reward scenarios observable on-chain.Cleans up
reversible-transfersby removing the unusedCallDecodingFailederror and expanding docs to explicitly state that high-security mode andrecover_fundsare intentionally permanent/repeatable. Expands the top-level documentation for thetreasurypallet to better explain its configuration-focused role.Reviewed by Cursor Bugbot for commit 54055b6. Bugbot is set up for automated code reviews on this repo. Configure here.