Skip to content

Conversation

@Fe-r-oz
Copy link
Contributor

@Fe-r-oz Fe-r-oz commented Sep 6, 2025

This PR adds minimum distance tests for the GeneralizedToricCode and improve documentation for TrivariateTricycleCode.

  • The code is properly formatted and commented.
  • Substantial new functionality is documented within the docs.
  • All new functionality is tested.
  • All of the automated tests on github pass.
  • We recently started enforcing formatting checks. If formatting issues are reported in the new code you have written, please correct them.

…prove the documentation for TrivariateTricycleCode
@Fe-r-oz Fe-r-oz added the Skip-Changelog label for control of CI: skips the changelog check label Sep 6, 2025
@codecov
Copy link

codecov bot commented Sep 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.36%. Comparing base (11dd3e5) to head (51bfd64).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #591      +/-   ##
==========================================
+ Coverage   85.32%   85.36%   +0.03%     
==========================================
  Files         123      123              
  Lines        7504     7504              
==========================================
+ Hits         6403     6406       +3     
+ Misses       1101     1098       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Fe-r-oz Fe-r-oz marked this pull request as ready for review September 6, 2025 18:51
@Fe-r-oz Fe-r-oz requested a review from nzy1997 September 6, 2025 20:36
@Fe-r-oz Fe-r-oz changed the title minor: add minimum distance tests for the GeneralizedToricCode and improve documentation for TrivariateTricycleCode add minimum distance tests for the GeneralizedToricCode and improve documentation for TrivariateTricycleCode Sep 8, 2025
Copy link
Member

@nzy1997 nzy1997 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the tests and the documentations!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Skip-Changelog label for control of CI: skips the changelog check

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants