Try to do SVD truncation on GPU with _ind_intersect #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your PR no longer requires formatting changes. Thank you for your contribution! |
Merged
lkdvos
approved these changes
Jan 8, 2026
Member
lkdvos
left a comment
lkdvos
left a comment
There was a problem hiding this comment.
I would say that if the tests pass here, we can revert the GPUArrays source thing and then just force-merge, since these changes have nothing to do with this PR to begin with (but it would be nice to verify that this implementation actually works).
I have no strong opinions on merging this before or after a tag.
lkdvos
reviewed
Jan 8, 2026
Co-authored-by: Lukas Devos <ldevos98@gmail.com>
Member
|
test failure is unrelated, will remove the GPUArrays source and merge this. |
This reverts commit fa9fa80.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this should be ok because the svd values should always be sorted (and the tests passed) but I'm not sure if that continues to be true for all the block-sparse tensors that may rely on this.